Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #429] Registration & Heartbeat Performance Optimization #440

Merged
merged 18 commits into from
Jun 21, 2022

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #429

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun added healthcheck test Unit testing and integration testing service Service registration discovery, service governance labels Jun 15, 2022
@chuntaojun chuntaojun requested review from lepdou and andrewshan and removed request for lepdou June 15, 2022 07:07
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #440 (7072fa2) into main (4632805) will increase coverage by 1.04%.
The diff coverage is 51.70%.

❗ Current head 7072fa2 differs from pull request most recent head 3fd9127. Consider uploading reports for the commit 3fd9127 to get more accurate results

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   22.17%   23.21%   +1.04%     
==========================================
  Files         185      186       +1     
  Lines       25159    25189      +30     
==========================================
+ Hits         5578     5848     +270     
+ Misses      18738    18441     -297     
- Partials      843      900      +57     
Impacted Files Coverage Δ
auth/defaultauth/server.go 2.23% <ø> (ø)
auth/defaultauth/server_authability.go 10.00% <0.00%> (ø)
cache/client.go 13.38% <0.00%> (ø)
cache/l5.go 12.04% <0.00%> (ø)
cache/namespace.go 27.41% <0.00%> (ø)
cache/routing_config.go 26.41% <0.00%> (ø)
cache/service_query.go 42.13% <0.00%> (ø)
cache/test_export.go 50.00% <ø> (ø)
config/server.go 0.00% <ø> (ø)
service/batch/future.go 51.61% <0.00%> (-15.06%) ⬇️
... and 27 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

service/instance.go Outdated Show resolved Hide resolved
service/batch/batch.go Outdated Show resolved Hide resolved
service/batch/future.go Outdated Show resolved Hide resolved
service/batch/future.go Outdated Show resolved Hide resolved
@chuntaojun chuntaojun added the keystone the key feature of the milestone label Jun 17, 2022
cache/cache.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keystone the key feature of the milestone service Service registration discovery, service governance test Unit testing and integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration & Heartbeat Performance Optimization
2 participants