Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #629 (#693) #698

Merged
merged 2 commits into from
Sep 25, 2022
Merged

fix issue #629 (#693) #698

merged 2 commits into from
Sep 25, 2022

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #692

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

* docs:优化错误信息描述

* Update zh.toml

* fix:修复eureka心跳协议错误码不兼容问题

* fix:修复eureka心跳协议错误码不兼容问题

* unit:添加单元测试

* test:调整测试配置文件位置

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #698 (2a5dd6f) into main (9ef8895) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   51.61%   51.59%   -0.02%     
==========================================
  Files         164      164              
  Lines       29547    29547              
==========================================
- Hits        15251    15246       -5     
- Misses      12232    12235       +3     
- Partials     2064     2066       +2     
Impacted Files Coverage Δ
cache/ratelimit_config.go 79.54% <0.00%> (-1.52%) ⬇️
store/sqldb/routing_config_v2.go 47.36% <0.00%> (-1.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun added bug Something isn't working config Configuration Center labels Sep 25, 2022
@chuntaojun chuntaojun added this to the v1.12.0 milestone Sep 25, 2022
@chuntaojun chuntaojun merged commit 2d3807b into polarismesh:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config Configuration Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

命名空间删除时,需要检查服务、配置分组是否都全部删除了
1 participant