Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test auth #718

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Unit test auth #718

merged 5 commits into from
Oct 9, 2022

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun
fix issue polarismesh#629 (polarismesh#693)
6e9c876 
* docs:优化错误信息描述

* Update zh.toml

* fix:修复eureka心跳协议错误码不兼容问题

* fix:修复eureka心跳协议错误码不兼容问题

* unit:添加单元测试

* test:调整测试配置文件位置

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692

* fix:issue polarismesh#692
@chuntaojun
docs:add error code desc
6300ff3
@chuntaojun
unittest:auth模块添加sqldb的测试覆盖
981b036
@chuntaojun
fix:修复auth下结合数据源的集成测试
343b65f
@codecov
Copy link

codecov bot commented Oct 8, 2022 •
edited
Loading

Codecov Report

Merging #718 (343b65f) into main (485ce28) will increase coverage by 1.21%.
The diff coverage is n/a.

❗ Current head 343b65f differs from pull request most recent head 612546b. Consider uploading reports for the commit 612546b to get more accurate results

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   54.21%   55.42%   +1.21%     
==========================================
  Files         165      165              
  Lines       29826    29826              
==========================================
+ Hits        16171    16532     +361     
+ Misses      11513    11092     -421     
- Partials     2142     2202      +60
Impacted Files Coverage Δ
cache/routing_config.go 64.96% <0.00%> (-1.19%) ⬇️
store/boltdb/handler.go 63.68% <0.00%> (+0.74%) ⬆️
store/sqldb/strategy.go 23.25% <0.00%> (+5.58%) ⬆️
common/model/auth.go 60.00% <0.00%> (+24.00%) ⬆️
store/sqldb/group.go 38.10% <0.00%> (+34.64%) ⬆️
store/sqldb/user.go 47.83% <0.00%> (+38.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun added test Unit testing and integration testing code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment labels Oct 9, 2022
@chuntaojun chuntaojun merged commit 905e01b into polarismesh:main Oct 9, 2022
@chuntaojun chuntaojun deleted the unit_test_auth branch October 21, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lepdou lepdou lepdou approved these changes

Assignees
No one assigned
Labels
code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment test Unit testing and integration testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chuntaojun @lepdou