Add lexical enviroment for the Debugger #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch clearly needs a description about why this is needed. |
polaroi8d
force-pushed
the
lexical-env
branch
2 times, most recently
from
0ee6b7a
to
c95a2fe
Compare
Add LEXICAL_ENV option to the build system. JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
polaroi8d
force-pushed
the
lexical-env
branch
from
4d559b8
to
7cef41d
Compare
zherczeg
reviewed
Oct 28, 2016
| @@ -9,6 +9,7 @@ Enum that contains the following elements: | |||
| - JERRY_INIT_SHOW_REGEXP_OPCODES - dump regexp byte-code to log after compilation | |||
| - JERRY_INIT_MEM_STATS - dump memory statistics | |||
| - JERRY_INIT_MEM_STATS_SEPARATE - dump memory statistics and reset peak values after parse | |||
| - JERRY_INIT_LEXICAL_ENV - enable the lexical environment for the debugger | |||
There was a problem hiding this comment.
This should be JERRY_INIT_DEBUGGER, and enables all features required by debugging. Otherwise this would be a too complex api.
zherczeg
reviewed
Oct 28, 2016
| @@ -1558,6 +1558,14 @@ parser_parse_statements (parser_context_t *context_p) /**< context */ | |||
| parser_stack_push_uint8 (context_p, PARSER_STATEMENT_START); | |||
| parser_stack_iterator_init (context_p, &context_p->last_statement); | |||
|
|
|||
| #ifdef DEBUGGER | |||
| /* Set lexical enviroment for the debugger*/ | |||
| if (JERRY_INIT_LEXICAL_ENV) | |||
There was a problem hiding this comment.
This is incorrect, you need to test the flag with the & operator. Check other jerry_init_flag_t flags.
zherczeg
reviewed
Oct 28, 2016
| @@ -23,6 +23,7 @@ set(FEATURE_ERROR_MESSAGES OFF CACHE BOOL "Enable error messages?") | |||
| set(FEATURE_VALGRIND OFF CACHE BOOL "Enable Valgrind support?") | |||
| set(FEATURE_VALGRIND_FREYA OFF CACHE BOOL "Enable Valgrind-Freya support?") | |||
| set(FEATURE_CPOINTER_32_BIT OFF CACHE BOOL "Enable 32 bit compressed pointers?") | |||
| set(FEATURE_LEXICAL_ENV OFF CACHE BOOL "Enable lexical environment?") | |||
There was a problem hiding this comment.
This should not be a build time option. The debugger is the build tiem option.
zherczeg
reviewed
Oct 28, 2016
| @@ -1558,6 +1558,14 @@ parser_parse_statements (parser_context_t *context_p) /**< context */ | |||
| parser_stack_push_uint8 (context_p, PARSER_STATEMENT_START); | |||
| parser_stack_iterator_init (context_p, &context_p->last_statement); | |||
|
|
|||
| #ifdef DEBUGGER | |||
There was a problem hiding this comment.
DEBUGGER should be JERRY_DEBUGGER, since we need to prefix all defines with JERRY_
added 2 commits
October 28, 2016 10:57
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
|
Thanks for the review @zherczeg, I've updated the PR. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the debugger is used all lexical environments with all bindings are created. This allows inspecting all bindings runtime.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu