Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query/physicalplan: Fix aggregations of nil values #27

Merged
merged 2 commits into from
Apr 6, 2022
Merged

query/physicalplan: Fix aggregations of nil values #27

merged 2 commits into from
Apr 6, 2022

Conversation

brancz
Copy link
Member

@brancz brancz commented Apr 6, 2022

I believe this fixes the panic reported in #26

kakkoyun
kakkoyun approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI has something else to say though :)

@brancz
Copy link
Member Author

brancz commented Apr 6, 2022

We are still in the process of fixing all lints, it appears to me that this didn't introduce any new ones so this is good to go then.

@brancz brancz merged commit 18aad10 into main Apr 6, 2022
@brancz brancz deleted the fix-agg branch April 6, 2022 07:43
@brancz brancz mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brancz @kakkoyun