722 snapshot tx changes #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a snapshot could contain tx that were >= the snapshot_tx. This worked fine due to the index dropping tx during replay that were >= tx already in the index. However it would be better for the future if snapshots actually only contained tx's up to the snapshot tx
asubiotto
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening this tx PR.
Snapshots now grab a write tx. This prevents from other writes coming in and getting compacted into L1+ before the snapshot completes thus allowing tx > snapshot_tx from making it into the snapshot.
Snapshots now also filter out any writes in L0 that are > snapshot_tx from the snapshot write.