Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user profile in repository selection dropdown #92

Closed
birkjernstrom opened this issue Apr 3, 2023 · 6 comments · Fixed by #182
Closed

Show user profile in repository selection dropdown #92

birkjernstrom opened this issue Apr 3, 2023 · 6 comments · Fixed by #182
Assignees

Comments

@birkjernstrom
Copy link
Member

Currently, in case user doesn't have an organization/repositories connected, we show a blank dropdown (except for the connect more repositories link).

Our frontend knows whether the user has organizations or not. In case they don't, we should showcase the users avatar + name as an "organization", i.e it will look the same as if they had installed the app on one of their personal repositories.

Design discussion
Do we want to add a small badge to these organizations at the root level showing the number of connected repositories? It would help clarify that there are connected repositories once/if they do actually connect repositories.

@birkjernstrom birkjernstrom added this to the alpha milestone Apr 3, 2023
@petterheterjag
Copy link
Contributor

Like this?
Screenshot 2023-04-12 at 11 46 29

@birkjernstrom
Copy link
Member Author

I like it. Do we have room to add "Repos" next to the number? Just to clarify/distinguish it from the typical "notifications" design? @petterheterjag

@petterheterjag
Copy link
Contributor

@birkjernstrom There's probably room, and we can meake the popover slighly wider if needed. Here are two versions, which one do you prefer?
Screenshot 2023-04-18 at 09 52 26

@birkjernstrom
Copy link
Member Author

Nice, I think it's better and clearer. Just to be difficult, I might want to go with a third option: Number in a rounded box and the text more muted outside of it to the right :)

@petterheterjag
Copy link
Contributor

@birkjernstrom Something like this then? :)

Screenshot 2023-04-18 at 13 16 04

@birkjernstrom
Copy link
Member Author

Felt obvious in my head, but seeing it in practice changed my mind. Too much going on and feels disconnected. Let's go with Option #1.

image

I made this change directly via this commit
30498ce

cc @zegl @petterheterjag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants