Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to Github App Install directly vs. flash /dashboard #1

Closed
birkjernstrom opened this issue Feb 20, 2023 · 2 comments
Closed

Redirect to Github App Install directly vs. flash /dashboard #1

birkjernstrom opened this issue Feb 20, 2023 · 2 comments
Labels
enhancement Enhancement of existing features and services

Comments

@birkjernstrom
Copy link
Member

birkjernstrom commented Feb 20, 2023 •
edited by polar-sh bot

Upon login/signup when we authenticate the user, we redirect them to/dashboard which in turn redirects to github.com/apps/polar-code/installations/new – redirect immediately instead of to /dashboard

Funding with Polar

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog :^)
Fund with Polar
birkjernstrom added a commit that referenced this issue Feb 22, 2023
@birkjernstrom
fix (#1): Use NullPool with SQLAlchemy in Celery tasks
fae98a8 
Need to improve this for the future, but at least we don't run into
asyncio issues due to shared connections improperly closed and handled
across celery tasks.
@birkjernstrom
Copy link
Member Author

Ugh... Typo made me reference the wrong issue number in the commit message.

@birkjernstrom birkjernstrom added the enhancement Enhancement of existing features and services label Feb 23, 2023
@birkjernstrom birkjernstrom added this to the private-alpha milestone Apr 3, 2023
@zegl
Copy link
Contributor

zegl commented Apr 18, 2023

Closing this as we've solved this differently now with #172

@zegl zegl closed this as completed Apr 18, 2023
@birkjernstrom birkjernstrom mentioned this issue Apr 21, 2023
Closed
@birkjernstrom birkjernstrom mentioned this issue Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of existing features and services
Projects
Polar
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zegl @birkjernstrom