Remove IssueReference and IssueDependency logic

[frankie567]

As discussed in #2771

The drawback with this change is that we'll no longer synchronize Pull Requests (before, they were synchronized if referenced from an issue).

IMO, this is acceptable; as we may want to introduce a complete synchronization of Pull Requests, enabling us to allow pledges on them.

Thoughts @birkjernstrom, @zegl?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
polar	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 4, 2024 3:12pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 4, 2024 3:12pm

[github-actions]

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
global	238.15 KB (🟢 -48 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/layout	32.35 KB	270.5 KB	77.28% (+/- <0.01%)
/maintainer/page	120.86 KB	359 KB	102.57% (🟢 -0.01%)
/new/page	17.56 KB	255.71 KB	73.06% (🟢 -0.01%)
/(topbar)/layout	123.85 KB	362 KB	103.43% (🟢 -0.44%)
/(topbar)/subscribe/success/page	64.03 KB	302.17 KB	86.34% (🟢 -0.02%)
/[organization]/(sidebar)/layout	126.41 KB	364.56 KB	104.16% (🟢 -0.01%)
/[organization]/(sidebar)/donate/page	84.66 KB	322.8 KB	92.23% (🟢 -0.01%)
/[organization]/(sidebar)/issues/page	98.8 KB	336.95 KB	96.27% (🟢 -0.99%)
/[organization]/(sidebar)/page	232.15 KB	470.29 KB	134.37% (🟢 -0.96%)
/[organization]/(sidebar)/posts/[postSlug]/page	141.28 KB	379.42 KB	108.41% (🟢 -0.96%)
/[organization]/(sidebar)/posts/page	171.97 KB	410.12 KB	117.18% (🟢 -1.03%)
/[organization]/(sidebar)/subscriptions/page	116.04 KB	354.19 KB	101.20% (🟢 -0.02%)
/[organization]/[repo]/layout	97.75 KB	335.9 KB	95.97% (🟢 -0.01%)
/[organization]/[repo]/issues/[number]/(create)/page	126.57 KB	364.72 KB	104.20% (🟢 -0.60%)
/[organization]/[repo]/page	207.39 KB	445.54 KB	127.30% (🟢 -0.93%)
/[organization]/[repo]/issues/[number]/status/page	114.75 KB	352.89 KB	100.83% (🟢 -1.03%)
/[organization]/subscribe/page	105.62 KB	343.77 KB	98.22% (🟢 -0.01%)
/backoffice/badge/page	24.44 KB	262.58 KB	75.02% (🟢 -0.01%)
/backoffice/layout	145.19 KB	383.33 KB	109.52% (🟢 -0.58%)
/backoffice/issue/[id]/page	31.86 KB	270.01 KB	77.15% (🟢 -0.02%)
/backoffice/pledges/page	36.58 KB	274.72 KB	78.49% (🟢 -0.01%)
/backoffice/rewards_pending/page	38.1 KB	276.25 KB	78.93% (🟢 -0.01%)
/maintainer/new/page	120.6 KB	358.74 KB	102.50% (🟢 -0.01%)
/(topbar)/(backer)/feed/page	194.79 KB	432.94 KB	123.70% (🟢 -1.03%)
/(topbar)/(backer)/layout	25.18 KB	263.33 KB	75.24% (🟢 -0.01%)
/(topbar)/(backer)/settings/page	92.88 KB	331.03 KB	94.58% (🟢 -0.01%)
/(topbar)/(backer)/funding/page	135.55 KB	373.7 KB	106.77% (🟢 -0.95%)
/(topbar)/(backer)/subscriptions/page	150.78 KB	388.92 KB	111.12% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/donations/donors/page	145.35 KB	383.5 KB	109.57% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/layout	145.19 KB	383.33 KB	109.52% (🟢 -0.58%)
/maintainer/[organization]/(topbar)/loading	115.43 KB	353.58 KB	101.02% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/donations/overview/page	216.48 KB	454.62 KB	129.89% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/funding/page	158.59 KB	396.73 KB	113.35% (🟢 -0.95%)
/maintainer/[organization]/(topbar)/initialize/page	125.99 KB	364.13 KB	104.04% (🟢 -1.00%)
/maintainer/[organization]/(topbar)/issues/badge/page	179.28 KB	417.42 KB	119.26% (🟢 -0.92%)
/maintainer/[organization]/(topbar)/issues/overview/page	164.8 KB	402.95 KB	115.13% (🟢 -0.96%)
/maintainer/[organization]/(topbar)/members/page	120.87 KB	359.02 KB	102.58% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/overview/page	229.28 KB	467.42 KB	133.55% (🟢 -0.96%)
/maintainer/[organization]/(topbar)/posts/analytics/page	236.89 KB	475.04 KB	135.72% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/posts/overview/page	314.13 KB	552.27 KB	157.79% (🟢 -0.95%)
/maintainer/[organization]/(topbar)/promote/page	149.57 KB	387.72 KB	110.78% (🟢 -0.63%)
/maintainer/[organization]/(topbar)/settings/page	133.2 KB	371.34 KB	106.10% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/subscriptions/benefits/page	185.34 KB	423.49 KB	121.00% (🟢 -0.02%)
/maintainer/[organization]/(topbar)/subscriptions/overview/page	232.88 KB	471.03 KB	134.58% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/subscriptions/tiers/[tier]/page	164.77 KB	402.92 KB	115.12% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/subscriptions/subscribers/page	169.35 KB	407.49 KB	116.43% (🟢 -0.14%)
/maintainer/[organization]/(topbar)/subscriptions/tiers/new/page	164.34 KB	402.48 KB	114.99% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/subscriptions/tiers/page	124.06 KB	362.21 KB	103.49% (🟢 -0.01%)
/maintainer/[organization]/(white)/posts/[post]/page	271.16 KB	509.3 KB	145.51% (🟢 -0.68%)
/maintainer/[organization]/(white)/layout	115.43 KB	353.58 KB	101.02% (🟢 -0.01%)
/maintainer/[organization]/(white)/loading	115.43 KB	353.58 KB	101.02% (🟢 -0.01%)
/maintainer/[organization]/(white)/posts/new/page	235.83 KB	473.98 KB	135.42% (🟢 -0.68%)
/(topbar)/(backer)/finance/account/page	105.88 KB	344.02 KB	98.29% (🟢 -0.13%)
/(topbar)/(backer)/finance/layout	96.16 KB	334.31 KB	95.52% (🟢 -0.62%)
/(topbar)/(backer)/finance/incoming/page	123.97 KB	362.12 KB	103.46% (🟢 -0.13%)
/(topbar)/(backer)/finance/issue-funding/page	43.76 KB	281.91 KB	80.54% (🟢 -0.12%)
/(topbar)/(backer)/finance/issue-funding/contributors/page	43.12 KB	281.27 KB	80.36% (🟢 -0.12%)
/(topbar)/(backer)/finance/outgoing/page	110.35 KB	348.49 KB	99.57% (🟢 -0.13%)
/(topbar)/(backer)/finance/rewards/page	40.67 KB	278.82 KB	79.66% (🟢 -0.12%)
/maintainer/[organization]/(topbar)/finance/account/page	104.6 KB	342.75 KB	97.93% (🟢 -0.13%)
/maintainer/[organization]/(topbar)/finance/layout	115.43 KB	353.58 KB	101.02% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/finance/incoming/page	122.8 KB	360.95 KB	103.13% (🟢 -0.13%)
/maintainer/[organization]/(topbar)/finance/outgoing/page	109.16 KB	347.31 KB	99.23% (🟢 -0.13%)
/maintainer/[organization]/(topbar)/finance/issue-funding/page	42.53 KB	280.67 KB	80.19% (🟢 -0.12%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout	115.43 KB	353.58 KB	101.02% (🟢 -0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/contributors/page	41.73 KB	279.88 KB	79.97% (🟢 -0.13%)
/maintainer/[organization]/(topbar)/finance/issue-funding/rewarded/page	41.73 KB	279.87 KB	79.96% (🟢 -0.12%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

[zegl]

I'm in favour! The only real feature where Pull Request data is currently used is in the Split Rewards modal, where authors of related PRs are pre-filled in the modal.

It's a lot of code for such a simple feature, and if we were to build it from scratch, this is definitely not how we'd build it.