Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: Better error handling in GitHub installation #3508

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

birkjernstrom
Copy link
Member

Sometimes users report an error during installation. I suspect it might
be that GitHub redirects back immediately, but might not have fully
completed the installation (worker tasks). So our API seems to fail
without us capturing/handling it properly.

Informing the user to attempt to reload + throwing the error so Sentry
logs it for us to debug more closely.

Sometimes users report an error during installation. I suspect it might
be that GitHub redirects back immediately, but might not have fully
completed the installation (worker tasks). So our API seems to fail
without us capturing/handling it properly.

Informing the user to attempt to reload + throwing the error so Sentry
logs it for us to debug more closely.
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:51pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 20, 2024 8:51pm
polar-next-js-example ⬜️ Ignored (Inspect) Jun 20, 2024 8:51pm

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/maintainer/page 621.37 KB 844.15 KB 241.19% (+/- <0.01%)
/(installation)/github/installation/page 65.45 KB 288.23 KB 82.35% (🟡 +0.02%)
/backoffice/layout 630.71 KB 853.49 KB 243.85% (+/- <0.01%)
/maintainer/new/page 621.1 KB 843.87 KB 241.11% (+/- <0.01%)
/docs/api-reference/[...endpoint]/page 454.74 KB 677.52 KB 193.58% (+/- <0.01%)
/docs/layout 603 KB 825.77 KB 235.94% (+/- <0.01%)
/docs/(mdx)/api-reference/authentication/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/layout 201.95 KB 424.73 KB 121.35% (+/- <0.01%)
/docs/(mdx)/api-reference/introduction/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/api-reference/github-actions/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/api-reference/webhooks/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/api-reference/polar-sdk/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/api-reference/webhooks/events/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/guides/overview/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/donations/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/ads/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/benefits/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/faq/for-backers/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/faq/for-maintainers/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/overview/faq/overview/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/issue-funding/getting-started/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/overview/issue-funding/overview/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/issue-funding/promote/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/issue-funding/reward-contributors/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/issue-funding/workflow/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/overview/newsletters/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/payments-taxes/page 197.35 KB 420.13 KB 120.04% (+/- <0.01%)
/docs/(mdx)/overview/subscriptions/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/docs/(mdx)/overview/support/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/maintainer/[organization]/(topbar)/layout 630.71 KB 853.49 KB 243.85% (+/- <0.01%)
/maintainer/[organization]/(topbar)/donations/overview/page 746.49 KB 969.26 KB 276.93% (+/- <0.01%)
/maintainer/[organization]/(topbar)/funding/page 650.08 KB 872.86 KB 249.39% (+/- <0.01%)
/maintainer/[organization]/(topbar)/issues/badge/page 640.84 KB 863.62 KB 246.75% (+/- <0.01%)
/maintainer/[organization]/(topbar)/members/page 619.75 KB 842.53 KB 240.72% (+/- <0.01%)
/maintainer/[organization]/(topbar)/overview/page 685.98 KB 908.76 KB 259.65% (+/- <0.01%)
/maintainer/[organization]/(topbar)/issues/overview/page 657.23 KB 880.01 KB 251.43% (+/- <0.01%)
/maintainer/[organization]/(topbar)/posts/analytics/page 739.57 KB 962.34 KB 274.96% (+/- <0.01%)
/maintainer/[organization]/(topbar)/products/benefits/page 707.67 KB 930.45 KB 265.84% (+/- <0.01%)
/maintainer/[organization]/(topbar)/posts/page 776.23 KB 999.01 KB 285.43% (+/- <0.01%)
/maintainer/[organization]/(topbar)/sales/overview/page 742.7 KB 965.48 KB 275.85% (+/- <0.01%)
/maintainer/[organization]/(topbar)/sales/orders/page 646.99 KB 869.77 KB 248.50% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/sales/subscriptions/page 660.65 KB 883.42 KB 252.41% (+/- <0.01%)
/maintainer/[organization]/(topbar)/products/overview/page 693.79 KB 916.57 KB 261.88% (+/- <0.01%)
/maintainer/[organization]/(topbar)/settings/page 634.04 KB 856.82 KB 244.80% (🟡 +0.01%)
/maintainer/[organization]/(white)/posts/new/page 720.03 KB 942.81 KB 269.37% (🟡 +0.01%)
/maintainer/[organization]/(white)/layout 615.12 KB 837.9 KB 239.40% (+/- <0.01%)
/maintainer/[organization]/(topbar)/settings/webhooks/endpoints/[id]/page 656.32 KB 879.1 KB 251.17% (+/- <0.01%)
/maintainer/[organization]/promote/page 636.59 KB 859.37 KB 245.53% (+/- <0.01%)
/maintainer/[organization]/promote/layout 615.12 KB 837.9 KB 239.40% (+/- <0.01%)
/maintainer/[organization]/(white)/posts/[post]/page 721.08 KB 943.85 KB 269.67% (+/- <0.01%)
/(landing)/(mdx)/careers/page 172.27 KB 395.05 KB 112.87% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/layout 615.12 KB 837.9 KB 239.40% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout 615.12 KB 837.9 KB 239.40% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@birkjernstrom birkjernstrom merged commit 143167c into main Jun 20, 2024
10 checks passed
@birkjernstrom birkjernstrom deleted the github/error-handling branch June 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant