Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: implement more advanced CORS handling #3530

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

frankie567
Copy link
Member

The goal is to allow external API callers to be able to do so in a cross-origin scenario but only with the Authorization header and a proper token: cookie authentication should be blocked for them and allowed only for our own allow-listed origins.

The goal is to allow external API callers to be able to do so in a cross-origin scenario *but* only with the `Authorization` header and a proper token: cookie authentication should be blocked for them and allowed only for our own allow-listed origins.
@frankie567 frankie567 enabled auto-merge (rebase) June 25, 2024 10:15
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
polar ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 10:15am
polar-next-js-example ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 10:15am

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@frankie567 frankie567 merged commit fee6d6a into main Jun 25, 2024
8 checks passed
@frankie567 frankie567 deleted the feat/advanced-cors branch June 25, 2024 10:18
Copy link

sentry-io bot commented Jun 25, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ HTTPStatusError: Client error '404 Not Found' for url 'https://discord.com/api/v10/guilds/1218730176297439332' polar.integrations.discord.endpoints.discord_gu... View Issue
  • ‼️ RequestFailed: Response(401, data_model=<class 'githubkit.versions.v2022_11_28.models.group_0003.BasicError'>) polar.integrations.github.endpoints.install View Issue
  • ‼️ RequestFailed: Response(403, data_model=<class 'githubkit.versions.v2022_11_28.models.group_0003.BasicError'>) polar.integrations.github.endpoints.github_call... View Issue
  • ‼️ TypeError: object RedirectResponse can't be used in 'await' expression polar.integrations.stripe.endpoints.stripe_conn... View Issue
  • ‼️ PrimaryRateLimitExceeded: (Response(403, data_model=typing.Any), datetime.timedelta(0)) polar.issue.endpoints.get_body View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant