Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connection names from sMRIPrep's anat_preproc_wf #1825

Closed
adelavega opened this issue Oct 15, 2019 · 2 comments
Closed

Update connection names from sMRIPrep's anat_preproc_wf #1825

adelavega opened this issue Oct 15, 2019 · 2 comments
Labels
critical effort: low Estimated low effort task impact: high Estimated high impact task

Comments

@adelavega
Copy link
Contributor

A recent PR in smriprep breaks connections between the anat and func preproc wfs:
nipreps/smriprep#108

Here:
https://github.com/poldracklab/fmriprep/blob/2c0a8b39af4fac7416ce5d242c45f86e4a195b91/fmriprep/workflows/base.py#L624

Should be an easy fix, I can submit a PR.
@oesteban oesteban changed the title smriprep master breaks connections between anat_preproc_wf and func_preproc_wf Update connection names from sMRIPrep's anat_preproc_wf Oct 15, 2019
@oesteban
Copy link
Member

As long as we do not release another patch release of 0.3.x, this should not be a problem. I have updated the title. Thanks for reporting!

@oesteban oesteban added critical effort: low Estimated low effort task impact: high Estimated high impact task labels Oct 15, 2019
@adelavega adelavega mentioned this issue Oct 15, 2019
Closed
@oesteban
Copy link
Member

oesteban commented Dec 4, 2019

PR has been merged. Not an issue anymore! Thanks Alejandro.

@oesteban oesteban closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical effort: low Estimated low effort task impact: high Estimated high impact task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update connection names from sMRIPrep's anat_preproc_wf adelavega/fmriprep
2 participants
@oesteban @adelavega