Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connection names from sMRIPrep's ``anat_preproc_wf`` #1825

Closed
adelavega opened this issue Oct 15, 2019 · 2 comments
Closed

Update connection names from sMRIPrep's ``anat_preproc_wf`` #1825

adelavega opened this issue Oct 15, 2019 · 2 comments

Comments

@adelavega
Copy link
Contributor

@adelavega adelavega commented Oct 15, 2019

A recent PR in smriprep breaks connections between the anat and func preproc wfs:
poldracklab/smriprep#108

Here:

('outputnode.t1_mask', 'inputnode.t1_mask'),

Should be an easy fix, I can submit a PR.

@oesteban oesteban changed the title smriprep master breaks connections between anat_preproc_wf and func_preproc_wf Update connection names from sMRIPrep's ``anat_preproc_wf`` Oct 15, 2019
@oesteban

This comment has been minimized.

Copy link
Contributor

@oesteban oesteban commented Oct 15, 2019

As long as we do not release another patch release of 0.3.x, this should not be a problem. I have updated the title. Thanks for reporting!

@oesteban oesteban added this to Triage in pipelines via automation Oct 15, 2019
@oesteban oesteban moved this from Triage to Next week's targets in pipelines Oct 15, 2019
@oesteban

This comment has been minimized.

Copy link
Contributor

@oesteban oesteban commented Dec 4, 2019

PR has been merged. Not an issue anymore! Thanks Alejandro.

@oesteban oesteban closed this Dec 4, 2019
pipelines automation moved this from Next week's targets to Done Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pipelines
  
Done
2 participants
You can’t perform that action at this time.