Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Sanitize inputs #687

Merged
merged 9 commits into from
Feb 15, 2018
Merged

[FIX] Sanitize inputs #687

merged 9 commits into from
Feb 15, 2018

Conversation

chrisgorgo
Copy link
Collaborator

Closes #684

This was referenced Feb 10, 2018
Merged
Closed
oesteban
oesteban reviewed Feb 12, 2018
View reviewed changes
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to connect the report from the Sanitize interface to the final report?.

requirements.txt Outdated
@@ -1,3 +1,3 @@
numpy>=1.12.0
niworkflows>=0.2.7
git+https://github.com/chrisfilo/niworkflows.git@21c0647bb7e42938e947334ab8c474c011fe3484#egg=niworkflows-0.3.1-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are planning on merging nipreps/niworkflows#221 and release first, so the requirements will finally be pinned to that new release, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - that's why this PR is still marked as WIP.

@chrisgorgo
Copy link
Collaborator Author

I don't know the MRIQC reporting framework well enough to assess how hard this would be. I can at least open an issue for this.

@chrisgorgo chrisgorgo changed the title [WIP] Sanitize inputs Sanitize inputs Feb 14, 2018
@chrisgorgo
Copy link
Collaborator Author

Ready to merge.

@oesteban
Copy link
Member

Could you roll back the latest commit? Since MRIQC has the automated script to update the changelog, this is not necessary anymore.

(supposing that your origin remote points to your fork of mriqc):

git reset --hard HEAD^
git push origin +fix/sanitize_inputs

@chrisgorgo
Copy link
Collaborator Author

done

@oesteban oesteban changed the title Sanitize inputs [FIX] Sanitize inputs Feb 15, 2018
@oesteban oesteban merged commit ca6b21c into nipreps:master Feb 15, 2018
@oesteban oesteban mentioned this pull request Feb 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgorgo @oesteban