hopefully fixed issue with pipe open on Windows

polettix · May 15, 2015 · 54c8573 · 54c8573
1 parent 47d5ef9
commit 54c8573
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Changes b/Changes
@@ -1,4 +1,7 @@
 {{$NEXT}}
+   - hopefully fixed issue with pipe open on Windows
+
+0.973_04  2015-05-10 18:34:31 Europe/Rome
    - performance enhancement upon sorting
    - added command-line options for sort selection
    - added documentation

diff --git a/lib/App/Sets/Sort.pm b/lib/App/Sets/Sort.pm
@@ -24,10 +24,9 @@ sub sort_filehandle {
    state $has_sort = ! $config->{internal_sort};
 
    if ($has_sort) {
-      if (open my $fh, '-|', 'sort', '-u', $filename) {
-         return $fh;
-      }
-      WARN "cannot use system sort, falling back to internal implementation";
+      my $fh;
+      eval { open $fh, '-|', 'sort', '-u', $filename } and return $fh;
+      WARN 'cannot use system sort, falling back to internal implementation';
       $has_sort = 0; # from now on, use internal sort
    }