Use attrs everywhere #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the docstrings are gone... See * python-attrs/attrs#8 * python-attrs/attrs#357
"Generally speaking, the moment you think that you need finer control over how your class is instantiated than what attrs offers, it's usually best to use a classmethod factory or to apply the builder pattern." http://www.attrs.org/en/stable/init.html#post-init-hook
|
I also removed converters, which means that I broke the API and will probably have to replace them by classmethods, as advised in the attrs documentation:
|
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 97.56% 98.98% +1.41%
==========================================
Files 12 12
Lines 1027 590 -437
==========================================
- Hits 1002 584 -418
+ Misses 25 6 -19
Continue to review full report at Codecov.
|
|
All tests are passing, so I'll go ahead and merge this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already passes all the tests locally.
Things that will have to be reworked:
Things I removed and I'd like to bring back:
Things I'd like to review:
default=Noneeverywhere)isinstance(we are inconsistently using positive and negative checks)__attrs_post_init__but we could use@x.validatorinstead http://www.attrs.org/en/stable/init.html#decorator)KNOWN_PROPERTIES(can I iterate overattrsproperties now instead?)Things I'd like to add in the future: