This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Avoid iterating results twice in propagation.py
#1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yash-10
force-pushed
the
Slight-propagation-optimization
branch
2 times, most recently
from
167c625
to
73085d2
Compare
S reformat smal fix SS
Yash-10
force-pushed
the
Slight-propagation-optimization
branch
from
73085d2
to
f39c1ed
Compare
Codecov Report
@@ Coverage Diff @@
## main #1286 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 81 81
Lines 4248 4248
Branches 361 354 -7
=======================================
Hits 3908 3908
Misses 258 258
Partials 82 82
Continue to review full report at Codecov.
|
jorgepiloto
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Looks good to me @Yash-10, no more comments by my side. Let us wait for @astrojuanlu approval too 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to solve a "TODO" in the
propagationmodule where the variableresultswas iterated twice.The resulting improvement is ~1s for propagation for 50 seconds.
Thanks!
Re-triggering still shows the tests as canceled. Maybe some remote issue.Not now