Changed Docs to Markdown Format from reStructuredText Format #1073
Conversation
Hello,
UPDATE: Fixed most of the errors. UPDATE 2: Fixed everything ... Ready to go 馃槃 |
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 75 75
Lines 3991 3991
Branches 343 343
=======================================
Hits 3573 3573
Misses 326 326
Partials 92 92 Continue to review full report at Codecov.
|
The builds are failing:
@DhruvSondhi could you please add the necessary modules to the Then mark this pull request as ready for review so we can have a closer look :) Great job fixing the remaining issues! |
0beff2f
to
311af8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work, thanks a lot @DhruvSondhi! 馃憦馃徑 There were a lot of challenges along the way, but you almost got it working. Even the autoapi and hoverxref extensions.
However, the notebook gallery lost several thumbnails and, most importantly, cell outputs. I think we should figure this out before merging this PR.
One obstacle might be that one can't register two processors for the same extension:
Extension error:
source_suffix '.md' is already registered
make: *** [Makefile:61: html] Error 2
One silly idea that I had was to use a different extension, like .nmd
, for notebooks. But I don't know if this breaks other stuff.
When we are out of silly ideas, I think we should get in touch with nbsphinx and executablebooks authors, with a Short, Self-Contained, Correct Example to reproduce the problem, and inquire about a way forward.
If combining these two systems is impossible, we should reach out to MyST-NB authors to ask whether a "gallery-like" feature is in scope.
And finally, if this is truly impossible, we could consider alternatives for the notebooks, like having only links to Binder. This has obviously pros and cons.
dc88556
to
aa006bc
Compare
After checking through all the documentation thus generated after the migration to Markdown, the following issues are found :
|
9862b9e
to
634615f
Compare
Closing and reopening to try to trigger pipelines. |
@DhruvSondhi, #1077 is not linked to Search. see #1079 |
ff72d45
to
6b3e036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Did a first superficial review and left some comments.
To clarify: the output looks great and I'm looking forward to merging this!
beb727d
to
20918c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge and I did not review everything in depth, but after a quick look on the output, I think this is ready to be merged! If we find small formatting issues, they can be fixed afterwards.
Congratulations @DhruvSondhi for this pull request! It was not an easy task and the final results are awesome 馃殌 |
Hello,
This PR aims to propose the idea of migration of the documentation from
.rst
format to.md
format for easier editing & maintenance 馃槃Implements #977