Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

#129 Ensure that "package_data" are included #139

Merged
merged 1 commit into from Aug 29, 2016

Conversation

pombredanne
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Aug 28, 2016

Current coverage is 81.67% (diff: 100%)

Merging #139 into master will not change coverage

@@             master       #139   diff @@
==========================================
  Files            23         23          
  Lines           906        906          
  Methods           0          0          
  Messages          0          0          
  Branches         71         71          
==========================================
  Hits            740        740          
  Misses          145        145          
  Partials         21         21          

Powered by Codecov. Last update 8401c3a...0c154cc

@astrojuanlu
Copy link
Member

Thanks a lot for the pull request! Would you mind explaining why did you add the zip_safe=False option?

@astrojuanlu
Copy link
Member

Well, now I see that if you don't explicitly state a value then setuptools does some weird analysis to determine it:

http://peak.telecommunity.com/DevCenter/setuptools#setting-the-zip-safe-flag

So I'm merging this PR as is. Thanks again!

@astrojuanlu astrojuanlu merged commit 573212e into poliastro:master Aug 29, 2016
@pombredanne
Copy link
Contributor Author

Would you mind explaining why did you add the zip_safe=False option?

Unless you are sure you could accommodate with accessing package data eventually in a zip, always use zip_safe=False to guarantee that the as-installed package will be unzipped (which is kinda of a moot point when using wheels that are always unzipped, but old habit die hard and eggs are still possible)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants