This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
raised error with message for negative tof value #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojuanlu
suggested changes
Dec 5, 2021
There was a problem hiding this comment.
Thanks for the pull request @TheBuffer!
However, this makes the change only in the izzo algorithm (while we also have vallado). And besides, the concept of "orbit epochs" doesn't exist at this low level function, it's only the tof, so I think the error message might be misleading.
What about moving the check upwards, to the Maneuver.lambert classmethod?
Codecov Report
@@ Coverage Diff @@
## main #1413 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 82 82
Lines 4348 4350 +2
Branches 426 427 +1
=======================================
+ Hits 3998 4000 +2
Misses 260 260
Partials 90 90
Continue to review full report at Codecov.
|
|
Also, this will need a test. |
TheBuffer
force-pushed
the
feature
branch
2 times, most recently
from
5a84de9
to
f295cff
Compare
astrojuanlu
suggested changes
Dec 6, 2021
TheBuffer
force-pushed
the
feature
branch
2 times, most recently
from
9fa77b6
to
225248f
Compare
for more information, see https://pre-commit.ci
astrojuanlu
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1397 Added message to negative tof assert error