Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Inspect numerical test failures #1512

Merged
merged 9 commits into from Jun 8, 2022

Conversation

astrojuanlu
Copy link
Member

Comes from #1511.

@astrojuanlu
Copy link
Member Author

Yep, main is broken at the moment.

@astrojuanlu
Copy link
Member Author

Docs are failing because:

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for url: https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/objects.inv
intersphinx inventory has moved: https://matplotlib.org/objects.inv -> https://matplotlib.org/stable/objects.inv

@astrojuanlu
Copy link
Member Author

Recent failure: https://app.circleci.com/pipelines/github/poliastro/poliastro/156/workflows/73475ba6-9623-4f9d-9cc2-26501820378c/jobs/6847

Last successful build on main: https://app.circleci.com/pipelines/github/poliastro/poliastro/142/workflows/bb55156a-6c8f-4550-9024-0f060bddbb9e/jobs/6738

These are some important dependency changes I noticed:

astropy 5.0.4 -> 5.1
numpy 1.21.6 -> 1.22.4
numba 0.55.1 -> 0.55.2
scipy 1.8.0 -> 1.8.1

Running the tests with NUMBA_DISABLE_JIT=1 locally makes them pass. And reverting to numba ==0.55.1 makes them pass too. Trying that out for now.

@astrojuanlu
Copy link
Member Author

It was not numba actually, it was a combination of latest Numba with latest NumPy: numba/numba#8141

@astrojuanlu
Copy link
Member Author

I'll enable automerge here. If all checks pass, we'll put this in.

@astrojuanlu
Copy link
Member Author

Still no dice 🙃 Will try one more thing

@astrojuanlu
Copy link
Member Author

Opened #1517 to address the xfail tests at some point.

@astrojuanlu astrojuanlu disabled auto-merge June 8, 2022 11:11
@astrojuanlu astrojuanlu merged commit d3648cb into poliastro:main Jun 8, 2022
@astrojuanlu astrojuanlu deleted the numerical-test-failures branch June 8, 2022 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant