Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

Remove magic delegation from Orbit objects #552

Merged
merged 1 commit into from Jan 29, 2019

Conversation

astrojuanlu
Copy link
Member

Fix #435, fix #370.

@ghost ghost assigned astrojuanlu Jan 29, 2019
@ghost ghost added the 2 - In Progress label Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #552 into master will decrease coverage by 0.02%.
The diff coverage is 88.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   84.44%   84.41%   -0.03%     
==========================================
  Files          52       52              
  Lines        2340     2323      -17     
  Branches      189      188       -1     
==========================================
- Hits         1976     1961      -15     
+ Misses        317      315       -2     
  Partials       47       47
Impacted Files Coverage Δ
src/poliastro/twobody/_states.py 75% <ø> (-4.32%) ⬇️
src/poliastro/maneuver.py 95.65% <100%> (-0.19%) ⬇️
src/poliastro/twobody/orbit.py 87.69% <87.69%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f48d44...0b0615e. Read the comment docs.

@astrojuanlu astrojuanlu merged commit acc8227 into poliastro:master Jan 29, 2019
@ghost ghost removed the 2 - In Progress label Jan 29, 2019
@astrojuanlu astrojuanlu deleted the remove-magic-properties branch January 29, 2019 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orbit properties are not discoverable Review poliastro Orbit design
1 participant