-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orekit validation first approach #4
Conversation
Let's not put it in the repo 🙏 Otherwise it will make the whole git history too sluggish. If it's a common Orekit thing we can point to the relevant documentation, or even provide a script to download it. I'll take a look at this tomorrow! |
I just saw that the Orekit wrapper provides a download data function. On the other hand, if the |
Some updates on this PR regarding previous suggestions and feedback I came up with the following structure: orekit/
├── README.md
├── requirements.txt
├── src/
└── tests/ The Regarding
Now, there exists a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on the right path! Left a few comments.
Sorry, I just forgot to update the README.md installation section guide. I will solve for this this night. |
I just added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go! 🚀
Merging! Thanks @jorgepiloto for taking this up and the patience 💪🏽 |
Oh, my bad... I now see that we merged |
Orekit validation first approach
|
This pull request is a first approach to poliastro's validation path. It makes use of the Orekit python wrapper and implements the following features:
A class under the name
OrekitOrbit
, who's usage is similar to poliastro'sOrbit
class. Both of them try to model Keplerian orbits, which can be defined from vectors or classic orbital elements.A simple test regarding the conversion between RV and COE.
rv2coe
orcoe2rv
, since conversion is done directly in each of the available constructors of theKeplerianOrbit
class in the Orekit libraryAlso notice the addition of the
orekit-data.zip
file, which holds necessary data for Orekit to properly work: ephemeris, time files... We might discuss if this data should be included within this repo or final user is required to download it from official channels.