Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment count without formatting to browse #177

Closed
wants to merge 1 commit into from

Conversation

slomo
Copy link
Contributor

@slomo slomo commented Oct 7, 2015

This is a first draft to add a comment counter to the browse page.

@cbotsikas
Copy link
Member

It's not comment_count anymore, its commentsCount. I'll add this on an upcomming PR.

@cbotsikas cbotsikas closed this Oct 7, 2015
@slomo
Copy link
Contributor Author

slomo commented Oct 7, 2015

You can't rename the variable since adhocracy will still attempt to write the old name. Also if this is an attempt to unify naming of objects members, I have to note that datasetmanager and metricsmanager use underscore and only some other services use camel case.

@cbotsikas
Copy link
Member

how will adhocracy attempt to write the old name?

@cbotsikas
Copy link
Member

this is the pr i mentioned earlier: #179

@slomo
Copy link
Contributor Author

slomo commented Oct 7, 2015

After a comment is added it will lookup the object from elastic search and write the new comment count to comment_count.

@cbotsikas
Copy link
Member

You should use search manager to invoke reindex for the specific object eg: http://services-stage.policycompass.eu/api/v1/searchmanager/updateindexitem/metric/26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants