Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands::Rspec does not catch single rspec failure #54

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

kowal
Copy link
Contributor

@kowal kowal commented Mar 31, 2016

Commands::Rspec does not catch single rspec failure o_O

Also I've fixed Tempfile.new usage for Ruby 2.2.4. Without that change CI was failing with ArgumentError: wrong number of arguments (0 for 1..2).

@kowal kowal changed the title rspec fails, rake does not Commands::Rspec does not catch single rspec failure Mar 31, 2016
@nijikon
Copy link
Contributor

nijikon commented Apr 3, 2016

@kowal Please rebase to one commit message.

@kowal kowal force-pushed the rspec_failures branch 2 times, most recently from fd22e07 to 911de1b Compare April 4, 2016 07:43
@kowal
Copy link
Contributor Author

kowal commented Apr 4, 2016

@nijikon done

@nijikon
Copy link
Contributor

nijikon commented Apr 4, 2016

@kowal Please add an entry to CHANGELOG

@kowal kowal force-pushed the rspec_failures branch 2 times, most recently from 2e39924 to 5bd3ab4 Compare April 4, 2016 08:07
@kowal
Copy link
Contributor Author

kowal commented Apr 5, 2016

@nijikon I've updated changelog.

@nijikon nijikon merged commit 21ef139 into polishgeeks:master Apr 5, 2016
@kowal
Copy link
Contributor Author

kowal commented Apr 7, 2016

@nijikon thanks
Don't you want to release 1.3.1 with that? Current 1.3.0 contains this bug and allows to silently ignore single test errors on CI. This stops us from upgrading.

@nijikon
Copy link
Contributor

nijikon commented Apr 7, 2016

I will release new version today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants