Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more unit user agent #77

Merged
merged 13 commits into from
May 27, 2019
Merged

Conversation

politeauthority
Copy link
Owner

No description provided.

@pep8speaks
Copy link

pep8speaks commented May 27, 2019

Hello @politeauthority! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 222:80: E501 line too long (86 > 79 characters)
Line 242:80: E501 line too long (81 > 79 characters)

Line 123:80: E501 line too long (88 > 79 characters)
Line 135:80: E501 line too long (116 > 79 characters)
Line 147:80: E501 line too long (87 > 79 characters)

Comment last updated at 2019-05-27 08:23:42 UTC

@politeauthority politeauthority merged commit 8e297d0 into 0.0.5 May 27, 2019
@politeauthority politeauthority deleted the feature/more-unit-user-agent branch May 27, 2019 08:30
politeauthority added a commit that referenced this pull request May 29, 2019
* Feature/more unit (#74)

* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Feature/more unit user agent (#77)

* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents

* Bringing back test__set_user_agent

* moar docs

* Feature/more unit (#78)

* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents

* Feature/more unit (#80)

* Brining back base init

* WIP

* make_request unit test back add

* version update

* Adding handle_sleep

* Removing handle_sleep for more work

* Updating test uri

* Feature/more unit handle sleep (#75)

* Adding back handle sleep

* Fixing unit tests

* Adding back test__get_headers

* Bringing back test__validate_conitentents

* adding fmt_request_args

* moar tests

* WIP

* Adding internal proxies param test

* Adding Parse tests

* updates

* Removing bad assert and fixing pep8 (#81)

* Upping arrow (#82)

* Adding some public method info (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants