Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (#35): Improve JSDoc comments for components #36

Merged
merged 2 commits into from Oct 26, 2020
Merged

Conversation

jackkoppa
Copy link
Contributor

@jackkoppa jackkoppa commented Oct 24, 2020

In addition to improving comments for props, events, and slots, also move 'custom options' stories to be within the primary stories Reduces complexity in left nav, while grouping all alike-stories together in UI main pain (i.e. all stories related to SelectMulti get to be together)

Closes #35

In addition to improving comments for props, events, and slots, also move 'custom options' stories to be within the primary stories
Reduces complexity in left nav, while grouping all alike-stories together in UI main pain (i.e. all stories related to SelectMulti get to be together)
@jackkoppa
Copy link
Contributor Author

Before

Screen Shot 2020-10-23 at 8 28 04 PM

After

Screen Shot 2020-10-23 at 8 27 54 PM

https://deploy-preview-36--vue-accessible-selects.netlify.app/?path=/docs/selectmulti--primary

@jackkoppa jackkoppa changed the title docs (35): Improve JSDoc comments for components docs (#35): Improve JSDoc comments for components Oct 24, 2020
Copy link
Contributor

@hungsu hungsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious! Very sensible 😀

@jackkoppa
Copy link
Contributor Author

Merging!

@jackkoppa jackkoppa merged commit ef8ecb1 into main Oct 26, 2020
@jackkoppa jackkoppa deleted the jackkoppa/docs/35 branch October 26, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Storybook stories documentation
2 participants