This repository has been archived by the owner on Aug 7, 2022. It is now read-only.
increase discoverability of auto-trim margins minor mode #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
politza
reviewed
Oct 27, 2017
lisp/pdf-view.el
Outdated
| @@ -286,6 +286,7 @@ regarding display of the region in the later function.") | |||
| (define-key map (kbd "s m") 'pdf-view-set-slice-using-mouse) | |||
| (define-key map (kbd "s b") 'pdf-view-set-slice-from-bounding-box) | |||
| (define-key map (kbd "s r") 'pdf-view-reset-slice) | |||
| (define-key map (kdb "t") 'pdf-view-auto-slice-minor-mode) | |||
There was a problem hiding this comment.
Should be kbd. Also, I would prefer s a as the binding.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added shortcut key to toggle auto-trim-margins mode (i.e.
pdf-view-auto-slice-minor-mode), and modified README accordingly. this is an incredibly useful feature for certain scanned documents and seems worth highlighting more prominently. (I ended up re-implementing it at first because the better-documenteds bis not terribly useful for scanned documents because it needs resetting each page. Later I came acrosspdf-view-auto-slice-minor-modeand realised that I'd just re-implemented its functionality.)