Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: command "query" must be executed on irc buffer (server or channel) #65

Open
ddevault opened this issue Mar 19, 2019 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@ddevault
Copy link

When using /query or clicking a username to attempt to start a PM with that person.

@poljar
Copy link
Owner

poljar commented Mar 19, 2019

Creating rooms sadly isn't implemented yet and I haven't thought about how we should present the user the different options while creating one.

The /query command should probably create a room with the preset of a trusted private chat and invite the user given as an argument. That room should also be marked as a direct one.

@poljar poljar added the enhancement New feature or request label Mar 19, 2019
@dkasak
Copy link
Collaborator

dkasak commented Mar 19, 2019

Also consider making /query USER bring you to the related buffer if a direct chat with USER already exists. There also needs to be a way to force creating a new room even if one exists already because that might sometimes be what is intended, though.

@ddevault
Copy link
Author

Inversely, closing a buffer doesn't seem to close that channel/user on the other end.

@poljar
Copy link
Owner

poljar commented Mar 19, 2019

The /part command does work. Leaving the room because the buffer is closed isn't implemented since the same callback gets called if a user closes a buffer or if weechat is closing down and closes the buffer, so that is a little bit tricky to implement as well.

@matthijskooijman
Copy link
Contributor

The /query command should probably create a room with the preset of a trusted private chat and invite the user given as an argument. That room should also be marked as a direct one.

Maybe see what Riot.im does and copy that?

@poljar
Copy link
Owner

poljar commented Sep 3, 2019

Riot has also some problems with this, a solution has been proposed here. So the query command would most likely utilize the create_dm API endpoint from the proposal, it makes things much easier for clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants