Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: view-builder #146

Merged
merged 14 commits into from
Nov 3, 2023
Merged

feat: view-builder #146

merged 14 commits into from
Nov 3, 2023

Conversation

josepot
Copy link
Member

@josepot josepot commented Nov 2, 2023

I still have to cleanup the code a bit and add a couple of tests, but it's already working. I've ran a few experiments and it seems to be working nicely. This PR includes a new experiment to test it out.

cc @peetzweg

@josepot josepot marked this pull request as ready for review November 2, 2023 22:45
@josepot josepot requested a review from kratico November 3, 2023 08:19
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

I would some unit tests to getViewBuilder

@josepot josepot added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit e674ae6 Nov 3, 2023
5 checks passed
@josepot josepot deleted the feat/view-builder branch November 3, 2023 22:58
wirednkod pushed a commit to wirednkod/polkadot-api that referenced this pull request Nov 7, 2023
voliva pushed a commit to voliva/polkadot-api that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants