add sql indexer behavior tests, remove restriction for normal sync #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
SyncStrategy::Normal- after review it was found that the existing behavior suffices for bothSyncStrategy::ParachainandSyncStrategy::Normal.It was decided not to index non-canonical blocks for now, since a valid use case was hard to find. If such a use-case arises in future, then the code allows the non-best blocks to be indexed as well with minimal changes, and can be addressed at that stage.
It was additionally considered that indexing non-canon blocks will negatively impact the index size of best-block tables for no immediate known advantage. Additionally keeping non-best block data in separate tables incurs development effort that is hard to justify as of now.
/cc @tgmichel