make rocksdb and paritydb optional #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhavyas
force-pushed
the
make_rocksdb_optional
branch
2 times, most recently
from
f24aa05
to
df553eb
Compare
Since `sc-cli` and `sc-service` brings rocksdb as default, workspace was adjusted to not use default features. Rest of the changes are ensuring necessary code is made optional.
vedhavyas
force-pushed
the
make_rocksdb_optional
branch
from
df553eb
to
9ecbbf5
Compare
sorpaas
approved these changes
Jun 23, 2023
Closed
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
sc-cliandsc-servicebrings rocksdb as default, workspace was adjusted to not use default features. Rest of the changes are ensuring necessary code is made optional.