Move manual seal node template under a feature flag #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's really weird why Truffle is generating different bytecode for contracts on my local machine vs Github Actions. |
|
I think this is related to trufflesuite/truffle-compile#77 :( |
|
Let's just remove the contract bytecode test for now. That's not really important. |
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* Move manual seal node template under a feature flag * Fix feature propogation * Fix tests * [WIP] Log GA-generated contract bytecode for debugging * [WIP] Comment out middle steps for faster debugging * Switch to dockerized truffle build * [WIP] Try a different solidity version * Remove debug GA workflow code * Remove bytecode match check in tests * Fix tests due to solc update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #315