pallet-base-fee storage utility functions
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,6 +242,21 @@ pub mod pallet { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Config> Pallet<T> { | |||
| pub fn set_base_fee_per_gas_inner(value: U256) -> Weight { | |||
There was a problem hiding this comment.
Can you explain the reason for doing this, it doesn't seem necessary.
There was a problem hiding this comment.
They are just some convenience functions to set the storage i.e. to update the storage values on runtime upgrade from outside the pallet or write integration tests.
sorpaas
reviewed
Feb 23, 2022
| @@ -239,6 +242,21 @@ pub mod pallet { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Config> Pallet<T> { | |||
| pub fn set_base_fee_per_gas_inner(value: U256) -> Weight { | |||
There was a problem hiding this comment.
Can you rename the name to without inner? I believe this won't conflict with Call as they are stored in a separate enum.
There was a problem hiding this comment.
Yeah I also believed that was the case and previously tried, but the compiler throws duplicate definitions error.
sorpaas
approved these changes
Feb 24, 2022
18 tasks
32 tasks
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* `pallet-base-fee` storage utility functions * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.