Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename from RxRpc to RpcRx in rpc-rx types #239

Closed
ltfschoen opened this issue Oct 10, 2018 · 1 comment
Closed

Rename from RxRpc to RpcRx in rpc-rx types #239

ltfschoen opened this issue Oct 10, 2018 · 1 comment

Comments

@ltfschoen
Copy link
Contributor

We have been using RpcRx to refer to rpc-rx. However in types defined for rpc-rx are prefixed with RxRpc https://github.com/polkadot-js/api/blob/master/packages/rpc-rx/src/types.d.ts

No objection was received to review comments of PR #233 when it was proposed to rename the prefixes from RxRpc to RpcRx in a separate PR.

Action is to

  • rename RxRpcInterface$Method to RpcRxInterface$Method
  • rename RxRpcInterface$Section to RpcRxInterface$Section
  • rename RxRpcInterface$Events to RpcRxInterface$Events
  • rename RxRpcInterface to RpcRxInterface
ltfschoen added a commit that referenced this issue Oct 10, 2018
@ltfschoen
refactor: Fixes #239. Rename from RxRpc to RpcRx in rpc-rx types
f117ebc
@jacogr jacogr closed this as completed in 3c8c4b0 Oct 11, 2018
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ltfschoen @polkadot-js-bot