Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS 6 #123

Merged
merged 5 commits into from Aug 7, 2018
Merged

RxJS 6 #123

merged 5 commits into from Aug 7, 2018

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Aug 7, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.947% when pulling 2bad94d on jg-rx-6 into fe4c34d on master.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

import { BehaviorSubject } from 'rxjs/BehaviorSubject';
import { Observable } from 'rxjs/Observable';
import { Subscriber } from 'rxjs/Subscriber';
import { BehaviorSubject , Observable, Subscriber } from 'rxjs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linter doesn't yell on this space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason not. However, I'm yelling :) Fixing...

@jacogr jacogr merged commit e2365bb into master Aug 7, 2018
@jacogr jacogr deleted the jg-rx-6 branch August 7, 2018 15:30
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants