Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string types inputs into codec #1292

Merged
merged 5 commits into from Aug 11, 2019
Merged

Allow string types inputs into codec #1292

merged 5 commits into from Aug 11, 2019

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Aug 11, 2019

This allows creation to be deferred as much as possible, all codec types allows string inputs and defers creation until needed. This also has additional effect in that createType now breaks the dependency on anything from primitive

@jacogr jacogr merged commit 1aa7899 into master Aug 11, 2019
@jacogr jacogr deleted the jg-code-string-types branch August 11, 2019 12:01
ianhe8x pushed a commit to plugblockchain/api.js that referenced this pull request Aug 14, 2019
* Allow string types inputs into codec

* Linkage allows string constructors

* Import case

* Cleanup keyof imports

* Attempt linkage doc fix
ianhe8x pushed a commit to plugblockchain/api.js that referenced this pull request Aug 14, 2019
* Allow string types inputs into codec

* Linkage allows string constructors

* Import case

* Cleanup keyof imports

* Attempt linkage doc fix
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants