New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Types from RPC (and more tests) #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
packages/api-codec/src/Type.ts
Outdated
this._ungeneric() | ||
this._ungeneric(), | ||
// convert `RawAddress` -> `Address` | ||
// convert `PropIndex` -> `ProposalIndex` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to unalias those 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left it in there on purpose... They were there originally. First one I probably want to do again (once I've read the Rust code), second according to Gav is not needed.
Related to #161 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Renames -