Intelligent constructor #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On-board with the |
8 tasks
jacogr
requested changes
Oct 5, 2018
packages/types/src/Text.ts
Outdated
| } else if (input instanceof Uint8Array) { | ||
| const [offset, length] = Compact.decode(input); | ||
| return u8aToUtf8(input.subarray(offset, offset + length.toNumber())); | ||
| } else if (Array.isArray(input)) { |
There was a problem hiding this comment.
I would propose removing Array until needed. As it stands we don't have anything coming in anymore as [...]
packages/types/src/codec/Struct.ts
Outdated
| : value[key] | ||
| ); | ||
| if (value instanceof Uint8Array) { | ||
| const [compactLength, typeLength] = Compact.decode(value.subarray(currentIndex)); |
There was a problem hiding this comment.
The length needs to be decoded by the child itself, not this one.
packages/types/src/codec/Struct.ts
Outdated
| @@ -43,30 +46,54 @@ export default class Struct < | |||
| }, {} as E); | |||
| } | |||
|
|
|||
| static decode <S, V, T> (Types: S, value: V | Array<any>, isTuple: boolean): T { | |||
| static decode<S, V, T> (Types: S, value: V | Array<any> | AnyU8a, isTuple: boolean): T { | |||
There was a problem hiding this comment.
Erk, the isTuple is a hold-over, I don't believe is is used anymore, Tuples do their own thing. (It was pre-changes when stuff still came in as Array<number>)
amaury1093
force-pushed
the
am-only-constructor
branch
from
bb0e0e1
to
9dd683a
Compare
jacogr
approved these changes
Oct 9, 2018
This was referenced Oct 11, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effort to remove all
fromJSONandfromU8afrom types, and initialize them solely via constructor. Their constructor should be intelligent enough to handle all kinds of inputs (incl. of course JSON and Uint8Array inputs).For consistency, I propose that this decoding/input handling be done in the static method
decode. The constructor will just call thisdecodemethod.Related #161.
Done in this PR: