Add Compact{16,32,64,128,256} #219
Conversation
jacogr
commented
Oct 6, 2018
jacogr
commented
- Closes Add Compact{8,16,32,64,128,256} coders #197
- Related Rework codecs & extrinsics for poc-3 compatibility #161
| } | ||
|
|
||
| fromU8a (input: Uint8Array): Bytes { | ||
| const [offset, length] = Compact.decode(input); | ||
| const [offset, length] = Compact.decodeU8a(input, DEFAULT_LENGTH_BITS); |
There was a problem hiding this comment.
Instead of adding DEFAULT_LENGTH_BITS as 2nd arg everywhere, you could add a default value for this 2nd arg in the function definition? (you'll probably make codeclimate happy too)
There was a problem hiding this comment.
It was that way originally, but it creates issues and bugs that look correct.
i.e. for numbers, you want the default to probaly be 64, but for lengths it needs to be 32. So made it explicit everywhere. (The issue is not an issue yet, but will be - all numbers will be compact encoded in the system, so want to make sure we pass the param through and not just forget about it.)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
