Round out ApiPromise examples #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
approved these changes
Oct 12, 2018
| const transfer = api.tx.balances.transfer(BOB_ADDR, 12345); | ||
|
|
||
| // sign the transaction using our account | ||
| transfer.sign(alice, aliceNonce); |
There was a problem hiding this comment.
Maybe sign should already take care of nonce? Not sure if it should go here, on in the combined api-observable.
There was a problem hiding this comment.
It it does return a promise, yes. Currently it just returns the observable. We had this chat a couple of days ago, not sure which way is best - I would love it to be optional as well. For now, not yet...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.