class Struct extends Map #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Oct 18, 2018
| @@ -147,19 +147,20 @@ export default class Method extends Struct { | |||
| } | |||
|
|
|||
| get args (): Array<Base> { | |||
| return (this.getAtIndex(1) as Struct<Base>).values(); | |||
| // FIXME This should return a Struct instead of an Array | |||
| return [...(this.get('args') as Struct).values()]; | |||
There was a problem hiding this comment.
@jacogr I think in the UI you use method.args() as an array. So Map or Array?
There was a problem hiding this comment.
Prefer array. Plus it is actually closer to .values()
|
@amaurymartiny dev PR merged. |
jacogr
approved these changes
Oct 18, 2018
| @@ -16,15 +16,15 @@ export class RxProposal extends Struct.with({ id: PropIndex, proposal: Proposal, | |||
| } | |||
|
|
|||
| get address (): AccountId { | |||
| return this.raw.address as AccountId; | |||
| return this.get('address') as AccountId; | |||
There was a problem hiding this comment.
+1
I def prefer this - less magic.
| // @ts-ignore FIXME | ||
| value[jsonKey] | ||
| ); | ||
| raw[key] = value[jsonKey as string] instanceof Types[key] |
There was a problem hiding this comment.
Nice! I really tried to fix that :)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #161.
Instead of doing all types at once, let's do one by one, so that it's an easier transition. During this transition, I still added
this.raw = this;in the Struct class.This is one of the bigger ones. Breaking changes:
Struct.keys()returns an iterator, not an arrayStruct.values()returns an iterator, not an arrayTODO: