Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final approval of utility as_multi leads to error in events #2179

Closed
philipstanislaus opened this issue Jan 23, 2020 · 6 comments · Fixed by #2182
Closed

Final approval of utility as_multi leads to error in events #2179

philipstanislaus opened this issue Jan 23, 2020 · 6 comments · Fixed by #2182
Labels

Comments

@philipstanislaus
Copy link
Contributor

I'm playing around with multisigs right now, but when I do the final approval, I see this error in the events:

Uncaught error. Something went wrong with the data extraction, resulting in an error log.

Steps to reproduce:

  1. Run: docker run -p 9933:9933 -p 9944:9944 -p 30333:30333 parity/substrate:2.0.0-14720148 --ws-external --rpc-external --dev
  2. Submit the first multisig extrinsic:

Bildschirmfoto 2020-01-22 um 16 28 28

3. Inspect the events to find the AccountId of the "2 of Alice, Bob" multisig by inspecting the events, here `5F3QVb...MCh4Ch`:

Bildschirmfoto 2020-01-22 um 16 30 20

4. Send funds to that AccountId:

Bildschirmfoto 2020-01-22 um 16 30 42

5. Submit the second (final) multisig extrinsic:

Bildschirmfoto 2020-01-22 um 16 31 42

6. Find the error in the logs:

Bildschirmfoto 2020-01-22 um 16 32 19

Many thanks for helping resolving this!

@jacogr
Copy link
Member

jacogr commented Jan 23, 2020

Brilliant! Thanks for the detailed report. This could very well be related to having an old implementation of DispatchError where the UI currently only supports the latest.

Will however follow along and attempt it on a current Substrate master.

Ummm... ok, looking at your screenshots again, it is on 204 (latest substrate), so def an issue.

@jacogr jacogr added +P3 bug and removed +P3 labels Jan 23, 2020
@jacogr
Copy link
Member

jacogr commented Jan 23, 2020

Just one question - do you have overrides for DispatchError in your types?

@philipstanislaus
Copy link
Contributor Author

philipstanislaus commented Jan 23, 2020

No, I’m actually running the substrate default node and the deployed Polkadot Apps (no overrides in the settings either).

Thanks for the blazing fast turnaround! 🚀

@jacogr
Copy link
Member

jacogr commented Jan 23, 2020

So 2 issues here -

  1. The actual Error metadata for utility is not exposed, this is fixed here - Expose Error in metadata for pallet-utility paritytech/substrate#4721
  2. When finding non-existent (as above), the UI will now fallback to displaying the module/error struct (aka allow for manual lookup, instead of just displaying nothing) - Handle DispatchError failures gracefully #2182

@philipstanislaus
Copy link
Contributor Author

Awesome, thanks!

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants