Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DispatchError failures gracefully #2182

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Jan 23, 2020

Closes #2179

@jacogr jacogr merged commit 09e974b into master Jan 23, 2020
@jacogr jacogr deleted the jg-handle-error-DispatchError branch January 23, 2020 12:52
satellitex added a commit to staketechnologies/apps that referenced this pull request Feb 12, 2020
* Adjust name weights

* [CI Skip]  0.39.0-beta.11

skip-checks: true

* Use lookup accountId for IdentiIcon display (polkadot-js#2065)

* [CI Skip]  0.39.0-beta.12

skip-checks: true

* Styling tweaks (polkadot-js#2066)

* Styling tweaks

* Linting

* [CI Skip]  0.39.0-beta.13

skip-checks: true

* (tiny) Badge styling updates (polkadot-js#2067)

* [CI Skip]  0.39.0-beta.14

skip-checks: true

* Disable contracts call RPC if unavailable (polkadot-js#2068)

* disable contract rpc

* bump

* [CI Skip]  0.39.0-beta.15

skip-checks: true

* Fix Identicon on-not-connected (polkadot-js#2070)

* [CI Skip]  0.39.0-beta.16

skip-checks: true

* Hide council voting when not a member (polkadot-js#2071)

* Hide council voting when not a member

* Disable instead of hide

* [CI Skip]  0.39.0-beta.17

skip-checks: true

* Add "send to council" to treasury (polkadot-js#2075)

* [CI Skip]  0.39.0-beta.18

skip-checks: true

* Add useTranslation for all apps (polkadot-js#2076)

* [CI Skip]  0.39.0-beta.19

skip-checks: true

* Display all identity info on hover (polkadot-js#2077)

* Display all identity info on hover

* Bump API

* displayName linting

* [CI Skip]  0.39.0-beta.20

skip-checks: true

* Provide judgement via account hover (polkadot-js#2078)

* Provide judgement via account hover

* Click to provide judgement

* [CI Skip]  0.39.0-beta.21

skip-checks: true

* Grayscale identity (polkadot-js#2079)

* [CI Skip]  0.39.0-beta.22

skip-checks: true

* Bump API (derives for proposals) (polkadot-js#2080)

* [CI Skip]  0.39.0-beta.23

skip-checks: true

* Cleanup display from identity (polkadot-js#2081)

* Cleanup display from identity

* Bump API

* [CI Skip]  0.39.0-beta.24

skip-checks: true

* Revert opacity adjustment

* [CI Skip]  0.39.0-beta.25

skip-checks: true

* Updae the council counter refresh (polkadot-js#2082)

* [CI Skip]  0.39.0-beta.26

skip-checks: true

* bump deps (polkadot-js#2088)

* [CI Skip]  0.39.0-beta.27

skip-checks: true

* Bump to latest api (polkadot-js#2089)

* Bump to latest api

* beta 17

* [CI Skip]  0.39.0-beta.28

skip-checks: true

* Disable spellcheck on input fields (polkadot-js#2090)

* [CI Skip]  0.39.0-beta.29

skip-checks: true

* Bump deps (polkadot-js#2091)

* [CI Skip]  0.39.0-beta.30

skip-checks: true

* Slash revert council proposal (polkadot-js#2093)

* Slash revert council proposal

* Disabled slashes when none

* [CI Skip]  0.39.0-beta.31

skip-checks: true

* Minor overflow adjustments (polkadot-js#2095)

* Minor overflow adjustments

* Default names to uppercase

* s/normal/none/

* isAddress check for text formatting

* Adjust caching with isAddress info

* Overflow to bottom

* [CI Skip]  0.39.0-beta.32

skip-checks: true

* Kulupu (polkadot-js#2092)

* Kulupu

* Add old DispatchInfo ovverride

* Old DispatchError & DispatchResult

* Moment typo

* [CI Skip]  0.39.0-beta.33

skip-checks: true

* Translation into Chinese (polkadot-js#2086)

* fix: init

* fix: 添加部分翻译

* fix: 完成账户翻译的验证

* fix: 添加汉语支持

* fix: 完成第一个阶段

* fix: 翻译部分内容

* fix:

* fix: 添加账户和合约的翻译

* fix: reset source config

* fix: reset source

* Fixup sidebar translation (polkadot-js#2096)

* Fixup sidebar translation

* Update transaltion extraction

* [CI Skip]  0.39.0-beta.34

skip-checks: true

* Some useTranslation updates (polkadot-js#2097)

* Some useTranslation updates

* AccountName caching

* [CI Skip]  0.39.0-beta.35

skip-checks: true

* Payment info display (polkadot-js#2003)

* Payment info display

* Bump deps

* Fee display

* [CI Skip]  0.39.0-beta.36

skip-checks: true

* Filter accounts/addresses by tag or name (polkadot-js#2102)

* Filter accounts/addresses by tag or name

* Filter identity names (as available)

* Adjust filter input label

* [CI Skip]  0.39.0-beta.37

skip-checks: true

* Lowercase filter (polkadot-js#2103)

* Lowercase filter

* Keep AccountId/AccountIndex mixed-case check

* Remove (unused) translation

* [CI Skip]  0.39.0-beta.38

skip-checks: true

* Bump API (Percentage, updated IdentityInfo) (polkadot-js#2104)

* [CI Skip]  0.39.0-beta.39

skip-checks: true

* Bump API (Proposal failsafe) (polkadot-js#2105)

* [CI Skip]  0.39.0-beta.40

skip-checks: true

* Remove FF warning (can now connect to local ws) (polkadot-js#2106)

* [CI Skip]  0.39.0-beta.41

skip-checks: true

* Display sub identities (polkadot-js#2107)

* [CI Skip]  0.39.0-beta.42

skip-checks: true

* Additional useTranslation conversions (polkadot-js#2109)

* Additional useTranslation conversions

* quotes

* Bumps

* Cleanup params wit overrides

* [CI Skip]  0.39.0-beta.43

skip-checks: true

* Staking filter (name, address) (polkadot-js#2110)

* Staking filter (name, address)

* Dislay parent & sub

* Formatting

* [CI Skip]  0.39.0-beta.44

skip-checks: true

* Own controller check on staking options (polkadot-js#2111)

* Own controller check on staking options

* Update SetSessionKey.tsx

* [CI Skip]  0.39.0-beta.45

skip-checks: true

* Bump deps (scan mirror) (polkadot-js#2112)

* [CI Skip]  0.39.0-beta.46

skip-checks: true

* Adjust sub name display (polkadot-js#2113)

* [CI Skip]  0.39.0-beta.47

skip-checks: true

* API 1.0-beta & common 2.0-beta (polkadot-js#2115)

* API 1.0-beta & common 2.0-beta

* May fix effect issue

* [CI Skip]  0.39.0-beta.48

skip-checks: true

* Common bump (no Alice stash in dev) (polkadot-js#2116)

* [CI Skip]  0.39.0-beta.49

skip-checks: true

* Cache pernt/child display parts (polkadot-js#2117)

* [CI Skip]  0.39.0-beta.50

skip-checks: true

* Bump API (polkadot-js#2121)

* [CI Skip]  0.39.0-beta.51

skip-checks: true

* Bump API (imOnline decoding) (polkadot-js#2122)

* [CI Skip]  0.39.0-beta.52

skip-checks: true

* Bump UI (chain settings) (polkadot-js#2125)

* [CI Skip]  0.39.0-beta.53

skip-checks: true

* Nominations lists text update (polkadot-js#2126)

* [CI Skip]  0.39.0-beta.54

skip-checks: true

* Additional useTranslation (polkadot-js#2118)

* Additional useTranslation

* Cleanup imports

* Cleanup unused props

* [CI Skip]  0.39.0-beta.55

skip-checks: true

* Connecting overlay rendering order (polkadot-js#2130)

* Connecting overlay rendering order

* API

* Combine components

* Unused import

* [CI Skip]  0.39.0-beta.56

skip-checks: true

* Always include staking favourites in the list (polkadot-js#2131)

* Always include staking favourites in the list

* Filter by actual session validators

* [CI Skip]  0.39.0-beta.57

skip-checks: true

* Add judgement waiting (polkadot-js#2134)

* [CI Skip]  0.39.0-beta.58

skip-checks: true

* Additional useTranslation usage (polkadot-js#2133)

* [CI Skip]  0.39.0-beta.59

skip-checks: true

* Display decoded ExtrinsicFailed errors (polkadot-js#2137)

* Display decoded ExtrinsicFailed errors

* Revert debug log

* Bump API (error lookup)

* [CI Skip]  0.39.0-beta.60

skip-checks: true

* Remove snippet sharing (polkadot-js#2138)

* [CI Skip]  0.39.0-beta.61

skip-checks: true

* API cleanups (polkadot-js#2139)

* API cleanups

* Revert ready setting

* ... oops

* Adjust dropdown right margin

* API -> functional

* [CI Skip]  0.39.0-beta.62

skip-checks: true

* No withCall for all functional (polkadot-js#2042)

* No withCall for all functional

* Linting

* Remove HOC, unneeded eslint override

* Cleanups

* [CI Skip]  0.39.0-beta.63

skip-checks: true

* Adjust overlays (polkadot-js#2142)

* [CI Skip]  0.39.0-beta.64

skip-checks: true

* Fix identity effect with twitter (polkadot-js#2145)

* [CI Skip]  0.39.0-beta.65

skip-checks: true

* Align noteImminent with Substrate (polkadot-js#2149)

* [CI Skip]  0.39.0-beta.66

skip-checks: true

* Swap council slashing cancel threshold to 50% (polkadot-js#2151)

* [CI Skip]  0.39.0-beta.67

skip-checks: true

* Bump deps (polkadot-js#2150)

* [CI Skip]  0.39.0-beta.68

skip-checks: true

* Remove IdentityInfo override (polkadot-js#2152)

* [CI Skip]  0.39.0-beta.69

skip-checks: true

* Society app (polkadot-js#2148)

* Society app

* useCheck

* Summary

* Updates

* Bump API with society

* Bump API (fixed publish)

* [CI Skip]  0.39.0-beta.70

skip-checks: true

* Democracy with useTranslation (polkadot-js#2153)

* Democracy with useTranslation

* Remove isSuspended display

* One isSubstrateV2 less

* Linting

* [CI Skip]  0.39.0-beta.71

skip-checks: true

* Bump API (incl. staking ledger fixes) (polkadot-js#2156)

* Bump API (incl. staking ledger fixes)

* Api context

* Replace counter

* Linting

* Swap t -> useTranslation

* Cleanup unwrap

* Rebuild i18n (& make auto-config)

* Remove old eslint override

* [CI Skip]  0.39.0-beta.72

skip-checks: true

* Set Modal default to open (polkadot-js#2157)

* [CI Skip]  0.39.0-beta.73

skip-checks: true

* useTranslation Suspense fallback (polkadot-js#2158)

* useTranslation Suspense fallback

* import path

* Some small useTranslation conversions

* [CI Skip]  0.39.0-beta.74

skip-checks: true

* Clear all window vars (polkadot-js#2159)

* Clear all window vars

* Cleanups

* [CI Skip]  0.39.0-beta.75

skip-checks: true

* Show society rotation & challenge periods (polkadot-js#2160)

* Shw rotation & challenge periods

* Display Bids

* [CI Skip]  0.39.0-beta.76

skip-checks: true

* Account create options, sort by created (polkadot-js#2161)

* [CI Skip]  0.39.0-beta.77

skip-checks: true

* Allow Qr scanning with name (polkadot-js#2163)

* [CI Skip]  0.39.0-beta.78

skip-checks: true

* Use ButtonCancel for all Cancel-only buttons (polkadot-js#2164)

* Use ButtonCancel for all Cancel-only buttons

* Small cleanups

* [CI Skip]  0.39.0-beta.79

skip-checks: true

* Auto-add Button.Group inside Modal.Actions (polkadot-js#2165)

* Auto-add Button.Group inside Modal.Actions

* Pass onCancel prop through to Modal.Actions

* Cancel rendering in contracts

* [CI Skip]  0.39.0-beta.80

skip-checks: true

* Cleanup AccountName display (polkadot-js#2166)

* [CI Skip]  0.39.0-beta.81

skip-checks: true

* Metadata update reload (polkadot-js#2143)

* Metadata update reload

* Check around status

* [CI Skip]  0.39.0-beta.82

skip-checks: true

* Remove last css files (all styled-components) (polkadot-js#2168)

* Additional css -> styled

* Apps class prefix renames

* Remove last css files

* Cleanup linked wrapper

* [CI Skip]  0.39.0-beta.83

skip-checks: true

* Fully split active/inactive nominations (polkadot-js#2169)

* [CI Skip]  0.39.0-beta.84

skip-checks: true

* xh members/candidates (society) (polkadot-js#2172)

* [CI Skip]  0.39.0-beta.85

skip-checks: true

* Swap Edgeware types to published (polkadot-js#2173)

* [CI Skip]  0.39.0-beta.86

skip-checks: true

* Swap council voting from TxModal (polkadot-js#2141)

* Swap council voting from TxModal

* Cleanup toggles

* Apply account filters

* useCouncilMembers

* Pass filter through to Propose

* Linting

* [CI Skip]  0.39.0-beta.87

skip-checks: true

* Handle DispatchError failures gracefully (polkadot-js#2182)

* Handle DispatchError failures gracefully

* Also allow queue display failures

* [CI Skip]  0.39.0-beta.88

skip-checks: true

* Allow sorting of staking returns (polkadot-js#2183)

* [CI Skip]  0.39.0-beta.89

skip-checks: true

* Adjust SI formats to full SI name (polkadot-js#2184)

* Adjust SI formats to full SI name

* Linting

* [CI Skip]  0.39.0-beta.90

skip-checks: true

* Bump API (polkadot-js#2186)

* [CI Skip]  0.39.0-beta.91

skip-checks: true

* Social account recovery (polkadot-js#2187)

* Social account recovery ... start

* Dialogs with send buttons

* TxButton icons (before I forget)

* Recovery start

* withSpinner

* [CI Skip]  0.39.0-beta.92

skip-checks: true

* Add Westend, externalize endpoints (polkadot-js#2171)

* Add Westend, externalize endpoints

* Update scanner with all current namespaces

* WebEnd type overrides

* Westend link to Polkascan

* [CI Skip]  0.39.0-beta.93

skip-checks: true

* Signer unlock password indicator (polkadot-js#2190)

* Signer unlock password indicator

* Combine UnlockError in Unlock

* [CI Skip]  0.39.0-beta.94

skip-checks: true

* Adjust available labels (polkadot-js#2191)

* [CI Skip]  0.39.0-beta.95

skip-checks: true

* Add preimage buttons to proposals (polkadot-js#2192)

* Add preimage buttons to proposals

* Styling overrides

* InputAddress filter

* [CI Skip]  0.39.0-beta.96

skip-checks: true

* Remove old votes from council (polkadot-js#2193)

* [CI Skip]  0.39.0-beta.97

skip-checks: true

* TxButton withSpinner swap (polkadot-js#2194)

* TxButton withSpinner swap

* TxModal onClick -> onStart (in modal)

* [CI Skip]  0.39.0-beta.98

skip-checks: true

* AddressMulti -> InputAddressMulti (polkadot-js#2195)

* [CI Skip]  0.39.0-beta.99

skip-checks: true

* Apply Vote conviction (polkadot-js#2197)

* [CI Skip]  0.39.0-beta.100

skip-checks: true

* Remove ja from i18n settings (polkadot-js#2198)

* [CI Skip]  0.39.0-beta.101

skip-checks: true

* Bump deps (polkadot-js#2199)

* [CI Skip]  0.39.0-beta.102

skip-checks: true

* Bump deps (polkadot-js#2202)

* Bump deps

* Re-apply v10-era linked check

* Expand key inline

* Expand type

* Extract exraction logic

* Latest API

* Fix linting around identity (now in metadata)

* Bump latest

* [CI Skip]  0.39.0-beta.103

skip-checks: true

* Society vouching (polkadot-js#2204)

* Society vouching

* Bump API, decode votes

* Inline count

* Remove unused style

* [CI Skip]  0.39.0-beta.104

skip-checks: true

* Staking list rendering optimizations (polkadot-js#2206)

* Staking list rendering optimizations

* Cleanups

* [CI Skip]  0.39.0-beta.105

skip-checks: true

* Convert options & items (tabs) to useMemo (polkadot-js#2207)

* Convert options & items (tabs) to useMemo

* Add missing var in useMemo

* Remove floating isSubstrateV2

* Cleanup staking entry

* Remove unneeded ?

* [CI Skip]  0.39.0-beta.106

skip-checks: true

* Bump API (polkadot-js#2208)

* [CI Skip]  0.39.0-beta.107

skip-checks: true

* Add derive availability failsafes (global) (polkadot-js#2210)

* Add derive availability failsafes (global)

* Check all isApiReady

* [CI Skip]  0.39.0-beta.108

skip-checks: true

* Empty heartbeats should not display (polkadot-js#2212)

* [CI Skip]  0.39.0-beta.109

skip-checks: true

* Bump deps (polkadot-js#2213)

* [CI Skip]  0.39.0-beta.110

skip-checks: true

* Squash session summary rendering (polkadot-js#2214)

* [CI Skip]  0.39.0-beta.111

skip-checks: true

* Adjust summary balance displays (polkadot-js#2215)

* Society voting on defender (polkadot-js#2216)

* Society voting on defender

* Bump deps

* Bump API (correct types)

* [CI Skip]  0.39.0-beta.112

skip-checks: true

* Bump deps (polkadot-js#2217)

* Bump deps

* Add extraction tests

* [CI Skip]  0.39.0-beta.113

skip-checks: true

* Bump API (polkadot-js#2219)

* [CI Skip]  0.39.0-beta.114

skip-checks: true

* Expose signed transactions (polkadot-js#2203)

* sign offline WIP

* signing transactions from extrinsics screen

* signing tx from accounts screen

* added translations

* removed unnecessary value

* removed console logs

* removed unused import

* used new signAsync method

* fixed types

* removed unused imports

* added missing translations

* code review changes

* fixed signing with local account

* added sign toggle

* improvements for QR

* [CI Skip]  0.39.0-beta.115

skip-checks: true

* 0.39 (polkadot-js#2220)

* 0.39

* Linting

* [CI Skip]  0.39.1

skip-checks: true

* Bump API (polkadot-js#2223)

* [CI Skip]  0.40.0-beta.0

skip-checks: true

* Bump API (polkadot-js#2224)

* Bump API

* Type adjustments

* Update zero const

* [CI Skip]  0.40.0-beta.1

skip-checks: true

* Add preimage button to externals (polkadot-js#2228)

* Add preimage button to externals

* Skip or on externals

* [CI Skip]  0.40.0-beta.2

skip-checks: true

* Bump deps (polkadot-js#2229)

* [CI Skip]  0.40.0-beta.3

skip-checks: true

* Change dockerfile to use local version as opposed to cloning polkadot… (polkadot-js#2225)

* Change dockerfile to use local version as opposed to cloning polkadot-js/apps

* Update Dockerfile

Co-authored-by: Jaco Greeff <jacogr@gmail.com>

* [CI Skip]  0.40.0-beta.4

skip-checks: true

* Build only apps component via docker (polkadot-js#2231)

* [CI Skip]  0.40.0-beta.5

skip-checks: true

* Bump deps (polkadot-js#2232)

* Bump deps

* Update types

* [CI Skip]  0.40.0-beta.6

skip-checks: true

* Display day breakdown for voting locks (polkadot-js#2234)

* [CI Skip]  0.40.0-beta.7

skip-checks: true

* Bump deps (polkadot-js#2238)

* [CI Skip]  0.40.0-beta.8

skip-checks: true

* Only update initial selected nominations once (polkadot-js#2241)

* [CI Skip]  0.40.0-beta.9

skip-checks: true

* Apply WS_URL consistently (polkadot-js#2244)

* [CI Skip]  0.40.0-beta.10

skip-checks: true

* Exapnd locks (& display all) (polkadot-js#2245)

* [CI Skip]  0.40.0-beta.11

skip-checks: true

* fix images

* build passed

* fix derive

* WIP: offer modal

* WIP add modal

* first impl trading

* add offers lists

* add trading lists

* passed lint

* passed build

Co-authored-by: Jaco Greeff <jacogr@gmail.com>
Co-authored-by: Keith Ingram <kwingram25@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: dushaobindoudou <dushaobindoudou@gmail.com>
Co-authored-by: Marcin Żółkiewski <zolkiewski.marcin@gmail.com>
Co-authored-by: philipstanislaus <6912756+philipstanislaus@users.noreply.github.com>
KarishmaBothara pushed a commit to cennznet/ui that referenced this pull request Feb 20, 2020
* Handle DispatchError failures gracefully

* Also allow queue display failures
jordy25519 pushed a commit to cennznet/ui that referenced this pull request Feb 20, 2020
* Handle DispatchError failures gracefully

* Also allow queue display failures
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final approval of utility as_multi leads to error in events
2 participants