Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow paste + enter on Dropdown #1937

Closed

Conversation

JunichiSugiura
Copy link
Contributor

@JunichiSugiura JunichiSugiura commented Nov 24, 2019

Close #1786

I think I nailed it this time while respecting current form architecture.

Old RP: #1930

Known issue: #1930 (comment)
I'll try to fix this in separate PR.

@jacogr
Copy link
Member

jacogr commented Nov 24, 2019

Thanks a million for the persistence - I’ll be able to give it a run-thought tomorrow.

@jacogr
Copy link
Member

jacogr commented Nov 25, 2019

This works as expected. I am just not convinced about this value={valueRef.current} - it means it actually doesn't force a re-render when the ref changes. I have not seens anything weird from it, however leaves me uncomfortable.

So it is a rock and a hard place - you don't want to use the only stateValue in the effect (it needs to be in params if used), but at the same time not sure using the bare ref as a value is 100% either.

@JunichiSugiura
Copy link
Contributor Author

it is a rock and a hard place...

Yea, I agree. Both solutions have some shortcomings.
I have some time today so I'm going to explore other approaches. Hopely find a better solution.

@jacogr jacogr mentioned this pull request Nov 30, 2019
@JunichiSugiura JunichiSugiura deleted the ls-hotfix-dropdown2 branch November 30, 2019 16:43
@jacogr
Copy link
Member

jacogr commented Nov 30, 2019

Thank you for the fix. It actually showed the underlying issues here - snuck in after the conversion to functional. (And still not perfect, but certainly better)

I really appreciate your work on this.

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow paste + enter to select pasted address
3 participants