Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Crust Network logos & endpoints #3598

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Added Crust Network logos & endpoints #3598

merged 3 commits into from
Sep 3, 2020

Conversation

badkk
Copy link
Contributor

@badkk badkk commented Sep 3, 2020

Description

Added endpoints, logos and spec of Crust Network

@yashirooooo
Add Crust Network logos & endpoints (#1)
3e496e0 
* Add Crust Network logos & endpoints

* fix

* fix

* fix
@yashirooooo
[CI] Fix yarn lint (#2)
5c9e943
jacogr
jacogr reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks spot-on. Would just appreciate some tweaks on the listing order (commented on them), it just makes management of all these easier when it is listed alphabetically. (There are a lot)

Sorry for being a pain here :)

packages/apps-config/src/api/spec/index.ts Outdated Show resolved Hide resolved
packages/apps-config/src/settings/endpoints.ts Outdated Show resolved Hide resolved
packages/apps-config/src/ui/general/index.ts Outdated Show resolved Hide resolved
packages/apps-config/src/ui/general/index.ts Outdated Show resolved Hide resolved
packages/apps-config/src/ui/logos/index.ts Outdated Show resolved Hide resolved
@badkk
Copy link
Contributor Author

badkk commented Sep 3, 2020

Functionality looks spot-on. Would just appreciate some tweaks on the listing order (commented on them), it just makes management of all these easier when it is listed alphabetically. (There are a lot)

Sorry for being a pain here :)

Sure, make sense to me 😃

jacogr
jacogr approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jacogr jacogr merged commit 846ceb8 into polkadot-js:master Sep 3, 2020
joelamouche pushed a commit to PureStake/apps that referenced this pull request Nov 3, 2020
@badkk @yashirooooo @joelamouche
Added Crust Network logos & endpoints (polkadot-js#3598)
57a741b 
* Add Crust Network logos & endpoints (#1)

* Add Crust Network logos & endpoints

* fix

* fix

* fix

* [CI] Fix yarn lint (#2)

* [CI] Fix alpha order lint (polkadot-js#3)

Co-authored-by: Yashiro <51014425+yuhui1208@users.noreply.github.com>
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@badkk @polkadot-js-bot @jacogr @yashirooooo