Split registrars display #6157
Split registrars display #6157
Conversation
|
It doesn't work when user has no accounts (the popup shows empty in this case). It's due to the |
|
hi, @krzysztof-jelski we've moved |
|
hi @jacogr, updated with master and ready for review :) |
| const judgementColor = useMemo(() => getJudgementColor(judgementName), [judgementName]); | ||
|
|
||
| return ( | ||
| <Popup |
There was a problem hiding this comment.
This is very weird - I can see the code, I can see your screenshot, but I don't get this info on my screen at all. Hover over the "Reasonable" and it is just, well, a cursor, no popup :)
There was a problem hiding this comment.
Some rebuild perhaps? With yarn clean and yarn build?
There was a problem hiding this comment.
The popup shows on click not on hover, did you try to click it?
There was a problem hiding this comment.
Ahhh... yes, not hover, click. (Not quite obvious to me :))
| color='yellow' | ||
| isTag={false} | ||
| key='NoJudgements' | ||
| label='No Judgements' |
There was a problem hiding this comment.
| label='No Judgements' | |
| label={t<string>('No Judgements')} |
| <Judgements | ||
| address={address} | ||
| /> |
There was a problem hiding this comment.
| <Judgements | |
| address={address} | |
| /> | |
| <Judgements address={address} /> |
Weird, could have sworn the linter would pick this up (single attribute, multiple lines)
|
Happy, this is a nice addition. However some tests are failing. |
|
Tests fixed ✅ |
|
@jacogr tests are fixed now, are you ok with us merging it? |
|
All happy. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If applied these changes will split displayed judgments (if those differ) and show registrars in popups: