Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to injected accounts in keyring load functions #464

Merged
merged 3 commits into from
May 11, 2021
Merged

Add types to injected accounts in keyring load functions #464

merged 3 commits into from
May 11, 2021

Conversation

joelamouche
Copy link
Contributor

  • add types to injected accounts
  • allows injecting account from MetaMask

@joelamouche
Copy link
Contributor Author

ready for review

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane, innocent and finally will only have an effect on the cases where special logic (like Ethereum types) are impacted. Thank you.

Now have a nagging doubt in my head if, as implemented, the apps UI actually works with contacts on chains such as Moonbeam. Since the info is not there, it seems like it may not work as expected. (And certainly didn't before the current beta of the keyring package)

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional type comments.

packages/ui-keyring/src/Keyring.ts Outdated Show resolved Hide resolved
packages/ui-keyring/src/Keyring.ts Outdated Show resolved Hide resolved
Co-authored-by: Jaco <jacogr@gmail.com>
@joelamouche
Copy link
Contributor Author

the apps UI actually works with contacts on chains such as Moonbeam

Like the dev accounts you mean? Are those part of the injected accounts? Aren't they added through the API?

Co-authored-by: Jaco <jacogr@gmail.com>
@joelamouche
Copy link
Contributor Author

ready for review @jacogr

@jacogr jacogr merged commit 99ee4af into polkadot-js:master May 11, 2021
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants