-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to injected accounts in keyring load functions #464
Add types to injected accounts in keyring load functions #464
Conversation
joelamouche
commented
May 6, 2021
- add types to injected accounts
- allows injecting account from MetaMask
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sane, innocent and finally will only have an effect on the cases where special logic (like Ethereum types) are impacted. Thank you.
Now have a nagging doubt in my head if, as implemented, the apps UI actually works with contacts on chains such as Moonbeam. Since the info is not there, it seems like it may not work as expected. (And certainly didn't before the current beta of the keyring package)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional type comments.
Co-authored-by: Jaco <jacogr@gmail.com>
Like the dev accounts you mean? Are those part of the injected accounts? Aren't they added through the API? |
Co-authored-by: Jaco <jacogr@gmail.com>
ready for review @jacogr |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |