Add support for runtime calls at other blocks than the most recent. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, this is a great addition. Looks good to me, I'll merge this and schedule for next release. There are some other contract interface changes upcoming, to keep it up to date with latest Substrate contract pallet changes (like inclusion of events in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often useful to
readcontracts at old blocks. For this it's necessary to be able to make runtime calls at old blocks. The appropriate RPC call in substrate supports this option -- this PR is adding the support here.I'm sorry if I missed something, like bumping version, running linter or things like that, but I wasn't sure how to do these things.