fix(license): remove license file #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the license file and uses the license field in meta data instead as the single source of declaring a license for a plugin or a recipe. Resolves pollination#154
Pull Request Test Coverage Report for Build 411289470Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
AntoineDao
reviewed
Dec 9, 2020
| if license_string is not None: | ||
| with open(os.path.join(folder_path, 'LICENSE'), 'w') as f: | ||
| f.write(license_string) | ||
| with open(os.path.join(folder_path, 'LICENSE'), 'w') as f: |
There was a problem hiding this comment.
Should we just drop the LICENSE file if we're not actually going to write anything there?
There was a problem hiding this comment.
I think it might still be helpful for user discovery. We can remove it at any point and it shouldn't break anything since it is only generated insider the folder when one uses to_folder.
AntoineDao
approved these changes
Dec 9, 2020
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the license file and uses the license field in meta data instead as the single source of declaring a license for a plugin or a recipe.
Resolves #154