Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional artifact #250

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

mostaphaRoudsari
Copy link
Member

This commit adds support for optional artifact inputs and outputs. This change will make it possible to support radiance recipes with BSDF materials.

@AntoineDao, I added an is_optional property to artifact input/outputs which can be used to update the extensions to support optional types.

@coveralls
Copy link

coveralls commented Jan 23, 2021

Pull Request Test Coverage Report for Build 506221767

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 35 (71.43%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 49.585%

Changes Missing Coverage Covered Lines Changed/Added Lines %
queenbee/io/common.py 2 3 66.67%
queenbee/io/inputs/dag.py 8 9 88.89%
queenbee/io/outputs/alias.py 6 7 85.71%
queenbee/io/outputs/dag.py 6 7 85.71%
queenbee/io/inputs/alias.py 3 9 33.33%
Totals Coverage Status
Change from base Build 506217418: 0.2%
Covered Lines: 1373
Relevant Lines: 2769

💛 - Coveralls

Copy link
Member

@AntoineDao AntoineDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this in just now so I can implement it on queenbee-argo ASAP.

@AntoineDao AntoineDao merged commit ba21e11 into pollination:master Jan 25, 2021
@ladybugbot
Copy link

🎉 This PR is included in version 1.22.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mostaphaRoudsari mostaphaRoudsari deleted the optional-artifact branch January 26, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants